[
https://issues.apache.org/jira/browse/DISPATCH-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17436488#comment-17436488
]
ASF GitHub Bot commented on DISPATCH-2272:
------------------------------------------
codecov-commenter edited a comment on pull request #1413:
URL: https://github.com/apache/qpid-dispatch/pull/1413#issuecomment-955701109
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1413?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1413](https://codecov.io/gh/apache/qpid-dispatch/pull/1413?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(164ce51) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/0a1459e190dbd489b30be3edef7a40d3dea27f0d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(0a1459e) will **increase** coverage by `0.09%`.
> The diff coverage is `91.17%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/1413?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
+ Coverage 84.67% 84.77% +0.09%
==========================================
Files 116 116
Lines 28591 28591
==========================================
+ Hits 24210 24238 +28
+ Misses 4381 4353 -28
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1413?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/dispatch.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2Rpc3BhdGNoLmM=)
| `86.85% <83.33%> (ø)` | |
|
[src/connection\_manager.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2Nvbm5lY3Rpb25fbWFuYWdlci5j)
| `89.04% <88.88%> (ø)` | |
|
[src/adaptors/tcp\_adaptor.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FkYXB0b3JzL3RjcF9hZGFwdG9yLmM=)
| `77.53% <100.00%> (+0.52%)` | :arrow_up: |
|
[src/alloc\_pool.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2FsbG9jX3Bvb2wuYw==)
| `93.72% <100.00%> (ø)` | |
|
[src/entity\_cache.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2VudGl0eV9jYWNoZS5j)
| `100.00% <100.00%> (ø)` | |
|
[src/log.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2xvZy5j)
| `91.31% <100.00%> (ø)` | |
|
[src/policy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3BvbGljeS5j)
| `87.31% <100.00%> (ø)` | |
|
[src/router\_agent.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9hZ2VudC5j)
| `90.90% <100.00%> (ø)` | |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.45% <100.00%> (-0.20%)` | :arrow_down: |
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `78.69% <0.00%> (-4.15%)` | :arrow_down: |
| ... and [12
more](https://codecov.io/gh/apache/qpid-dispatch/pull/1413/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1413?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1413?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Last update
[0a1459e...164ce51](https://codecov.io/gh/apache/qpid-dispatch/pull/1413?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
Read the [comment
docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Mark all functions called from Python with QD_EXPORT
> ----------------------------------------------------
>
> Key: DISPATCH-2272
> URL: https://issues.apache.org/jira/browse/DISPATCH-2272
> Project: Qpid Dispatch
> Issue Type: Sub-task
> Affects Versions: 1.17.0
> Reporter: Jiri Daněk
> Priority: Major
>
> Dispatch requires that all C functions it calls be exported, because it looks
> them up as if in a dynamic library. This is important on Windows, where
> functions are unexported by default.
> On Windows, use {{__declspec(dllexport)}} to turn on exporting. Without it,
> the functions will not be found from Python.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
