[
https://issues.apache.org/jira/browse/DISPATCH-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437441#comment-17437441
]
ASF GitHub Bot commented on DISPATCH-1958:
------------------------------------------
kgiusti commented on pull request #1416:
URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957878563
hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS
non-configurable? IOW, get rid of the flag and just always provide memory
statistics. It's pretty obvious we haven't tested QD_MEMORY_STATS=OFF as part
of our CI.
Just an opinion, thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Qdstat throws exception when router compiled with `DQD_MEMORY_STATS=OFF`
> ------------------------------------------------------------------------
>
> Key: DISPATCH-1958
> URL: https://issues.apache.org/jira/browse/DISPATCH-1958
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Tools
> Affects Versions: 1.15.0
> Reporter: Jiri Daněk
> Assignee: Ganesh Murthy
> Priority: Major
> Fix For: 1.18.0
>
>
> From the README
> {noformat}
> -DQD_MEMORY_STATS=
> ------------------
> Dispatch will track memory pool usage statistics if this is enabled.
> {noformat}
> So the statistics may not be always available, depending on the way
> Dispatch is compiled.
> Allocator metrics get reported as 0. I see that {{qdmanage}} works just fine,
> but {{qdstat}} is throwing an error in such case:
> {noformat}
> $ qdstat -m
> 2021-02-04 15:08:19.288818 UTC
> Standalone_v++jCPCjYiQcGo3
> TypeError: unsupported operand type(s) for *: 'int32' and 'NoneType'
> {noformat}
> Found during PR review by [~fgiorget].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
