[
https://issues.apache.org/jira/browse/DISPATCH-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17443183#comment-17443183
]
ASF GitHub Bot commented on DISPATCH-2036:
------------------------------------------
jiridanek commented on a change in pull request #1434:
URL: https://github.com/apache/qpid-dispatch/pull/1434#discussion_r748761192
##########
File path: src/router_core/modules/stuck_delivery_detection/delivery_tracker.c
##########
@@ -46,15 +46,19 @@ struct tracker_t {
static void check_delivery_CT(qdr_core_t *core, qdr_link_t *link,
qdr_delivery_t *dlv)
{
- if (!dlv->stuck && ((core->uptime_ticks - link->core_ticks) > stuck_age)) {
- dlv->stuck = true;
- link->deliveries_stuck++;
- core->deliveries_stuck++;
- if (link->deliveries_stuck == 1)
- qd_log(core->log, QD_LOG_INFO,
- "[C%"PRIu64"][L%"PRIu64"] "
- "Stuck delivery: At least one delivery on this link has
been undelivered/unsettled for more than %d seconds",
- link->conn ? link->conn->identity : 0, link->identity,
stuck_age);
+ // DISPATCH-2036: ignore "infinitely long" streaming messages (like TCP
+ // adaptor deliveries)
+ if (dlv->msg && !qd_message_is_streaming(dlv->msg)) {
+ if (!dlv->stuck && ((core->uptime_ticks - link->core_ticks) >
stuck_age)) {
Review comment:
```suggestion
// DISPATCH-2036: ignore "infinitely long" streaming messages (like TCP
// adaptor deliveries)
if (dlv->msg && qd_message_is_streaming(dlv->msg)) {
return;
}
if (!dlv->stuck && ((core->uptime_ticks - link->core_ticks) >
stuck_age)) {
[....]
```
Mostly aesthetics, but keeping the level of indentation down is often
helpful...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> TCP adaptor deliveries reported as "stuck" by delayed delivery detection
> ------------------------------------------------------------------------
>
> Key: DISPATCH-2036
> URL: https://issues.apache.org/jira/browse/DISPATCH-2036
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Protocol Adaptors
> Affects Versions: 1.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.19.0
>
>
> Since TCP adaptor uses long lived deliveries the delayed delivery detection
> logic flags these deliveries as stuck. This occurs on each intermediate
> router as well.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
