[
https://issues.apache.org/jira/browse/DISPATCH-2267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445172#comment-17445172
]
ASF GitHub Bot commented on DISPATCH-2267:
------------------------------------------
ted-ross commented on a change in pull request #1435:
URL: https://github.com/apache/qpid-dispatch/pull/1435#discussion_r751250679
##########
File path: src/router_core/address_watch.c
##########
@@ -0,0 +1,160 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include "router_core_private.h"
+#include "qpid/dispatch/amqp.h"
+
+struct qdr_address_watch_t {
+ DEQ_LINKS(struct qdr_address_watch_t);
+ qdr_watch_handle_t watch_handle;
+ char *address_hash;
+ qdr_address_watch_update_t handler;
+ void *context;
+};
+
+ALLOC_DECLARE(qdr_address_watch_t);
+ALLOC_DEFINE(qdr_address_watch_t);
+
+static void qdr_watch_invoker(qdr_core_t *core, qdr_general_work_t *work);
+static void qdr_core_watch_address_CT(qdr_core_t *core, qdr_action_t *action,
bool discard);
+static void qdr_core_unwatch_address_CT(qdr_core_t *core, qdr_action_t
*action, bool discard);
+static void qdr_address_watch_free_CT(qdr_address_watch_t *watch);
+
+//==================================================================================
+// Core Interface Functions
+//==================================================================================
+qdr_watch_handle_t qdr_core_watch_address(qdr_core_t *core,
+ const char *address,
+ char aclass,
+ char phase,
+ qdr_address_watch_update_t on_watch,
+ void *context)
+{
+ static sys_atomic_t next_handle;
+ qdr_action_t *action = qdr_action(qdr_core_watch_address_CT,
"watch_address");
+
+ action->args.io.address = qdr_field(address);
+ action->args.io.address_class = aclass;
+ action->args.io.address_phase = phase;
+ action->args.io.watch_handler = on_watch;
+ action->args.io.context = context;
+ action->args.io.value32_1 = sys_atomic_inc(&next_handle);
+
+ qdr_action_enqueue(core, action);
+ return action->args.io.value32_1;
+}
+
+
+void qdr_core_unwatch_address(qdr_core_t *core, qdr_watch_handle_t handle)
+{
+ qdr_action_t *action = qdr_action(qdr_core_unwatch_address_CT,
"unwatch_address");
+
+ action->args.io.value32_1 = handle;
+ qdr_action_enqueue(core, action);
+}
+
+
+//==================================================================================
+// In-Core API Functions
+//==================================================================================
+void qdr_trigger_address_watch_CT(qdr_core_t *core, qdr_address_t *addr)
+{
+ const char *address_hash = (char*)
qd_hash_key_by_handle(addr->hash_handle);
+ qdr_address_watch_t *watch = DEQ_HEAD(core->addr_watches);
+
+ while (!!watch) {
+ if (strcmp(watch->address_hash, address_hash) == 0) {
+ qdr_general_work_t *work = qdr_general_work(qdr_watch_invoker);
+ work->watch_handler = watch->handler;
+ work->context = watch->context;
+ work->local_consumers = DEQ_SIZE(addr->rlinks);
+ work->in_proc_consumers = DEQ_SIZE(addr->subscriptions);
+ work->remote_consumers = qd_bitmask_cardinality(addr->rnodes);
+ work->local_producers = DEQ_SIZE(addr->inlinks);
+ qdr_post_general_work_CT(core, work);
+ }
+ watch = DEQ_NEXT(watch);
+ }
+}
+
+void qdr_address_watch_shutdown(qdr_core_t *core)
+{
+ qdr_address_watch_t *watch = DEQ_HEAD(core->addr_watches);
+ while (!!watch) {
+ DEQ_REMOVE(core->addr_watches, watch);
+ qdr_address_watch_free_CT(watch);
+ watch = DEQ_HEAD(core->addr_watches);
+ }
+}
+
+
+//==================================================================================
+// Local Functions
+//==================================================================================
+static void qdr_address_watch_free_CT(qdr_address_watch_t *watch)
+{
+ free(watch->address_hash);
+ free_qdr_address_watch_t(watch);
+}
+
+
+static void qdr_watch_invoker(qdr_core_t *core, qdr_general_work_t *work)
+{
+ work->watch_handler(work->context,
+ work->local_consumers, work->in_proc_consumers,
work->remote_consumers, work->local_producers);
+}
+
+
+static void qdr_core_watch_address_CT(qdr_core_t *core, qdr_action_t *action,
bool discard)
Review comment:
Yes, it should. I'll make this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add a core-thread facility to allow IO modules to subscribe to
> address-reachability data
> ----------------------------------------------------------------------------------------
>
> Key: DISPATCH-2267
> URL: https://issues.apache.org/jira/browse/DISPATCH-2267
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Router Node
> Reporter: Ted Ross
> Assignee: Ted Ross
> Priority: Major
> Fix For: 1.19.0
>
>
> Add a facility to the Core Thread that allows an IO-thread module to register
> for updates about a particular address. Callbacks into the IO-thread (on an
> IO thread) shall inform the module about changes to the reachability of an
> address.
> This can be used by a protocol listener to open or close the listening socket
> for a protocol listener based on the availability of remote connectors.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
