[
https://issues.apache.org/jira/browse/PROTON-2406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17449481#comment-17449481
]
ASF GitHub Bot commented on PROTON-2406:
----------------------------------------
DreamPearl commented on pull request #337:
URL: https://github.com/apache/qpid-proton/pull/337#issuecomment-979809877
> Regardless, I think I would expect this example to have no reference to
reconnect_options unless non-default values were being set and no call made to
connection::reconnect().
@cliffjansen Yep, fixed!
> The segfault appears to be from a missing argument where argc is one short
to catch the expected number of input parameters. However, it may also be a
failing in the library to not robustly handle an empty vector properly.
The segfault fix PR is now merged
[PROTON-2441](https://github.com/apache/qpid-proton/pull/338). It was failing
in the library, connection_options::failover_urls wasn't able to handle an
empty vector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] Use of reconnect_options::failover_urls triggers
> -Wdeprecated-declarations in examples/cpp/reconnect_client.cpp
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: PROTON-2406
> URL: https://issues.apache.org/jira/browse/PROTON-2406
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding, examples
> Affects Versions: proton-c-0.36.0
> Reporter: Jiri Daněk
> Assignee: Rakhi Kumari
> Priority: Minor
> Fix For: proton-c-0.37.0
>
>
> {noformat}
> [ 56%] Building CXX object
> CMakeFiles/reconnect_client.dir/reconnect_client.cpp.o
> /usr/share/proton/examples/cpp/reconnect_client.cpp: In member function
> ‘virtual void reconnect_client::on_container_start(proton::container&)’:
> /usr/share/proton/examples/cpp/reconnect_client.cpp:59:35: warning:
> ‘proton::reconnect_options& proton::reconnect_options::failover_urls(const
> std::vector<std::basic_string<char> >&)’ is deprecated (declared at
> /usr/include/proton/reconnect_options.hpp:82): use
> connection_options::failover_urls() [-Wdeprecated-declarations]
> ro.failover_urls(failovers);
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
