[
https://issues.apache.org/jira/browse/DISPATCH-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17461014#comment-17461014
]
ASF GitHub Bot commented on DISPATCH-2300:
------------------------------------------
ganeshmurthy commented on a change in pull request #1463:
URL: https://github.com/apache/qpid-dispatch/pull/1463#discussion_r770870878
##########
File path: tests/system_tests_log_level_update.py
##########
@@ -256,56 +256,69 @@ def router(name, connection):
def test_inter_router_protocol_trace(self):
qd_manager = QdManager(self, self.address)
- # Turn off trace logging on all connections for Router B.
- qd_manager.update("org.apache.qpid.dispatch.log", {"enable": "info+"},
- name="log/DEFAULT")
+ # The router already has trace logging turned on for all connections.
# Get the connection id of the inter-router connection
results = qd_manager.query("org.apache.qpid.dispatch.connection")
conn_id = None
for result in results:
if result['role'] == 'inter-router':
conn_id = result['identity']
- # Turn on trace logging for the inter-router connection
- qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "true"}, identity=conn_id)
+ # Turn off trace logging for the inter-router connection. This update
command is run async by the router
+ # so we need to sleep a bit before the operation is actually completed.
+ qd_manager.update("org.apache.qpid.dispatch.connection",
{"enableProtocolTrace": "false"}, identity=conn_id)
+ time.sleep(1)
Review comment:
Unfortunately there is not. We could query the connection again to find
out but even if that has the correct value of enableProtocolTrace, it does not
guarantee that the action actually has executed. See here -
https://github.com/apache/qpid-dispatch/blob/main/src/router_core/agent_connection.c#L644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> system_tests_log_level_update failing when run against latest proton master
> ---------------------------------------------------------------------------
>
> Key: DISPATCH-2300
> URL: https://issues.apache.org/jira/browse/DISPATCH-2300
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Major
>
> {noformat}
> 67: # Give some time for the MAU to go over the inter-router link
> 67: time.sleep(2)
> 67: logs = qd_manager.get_log()
> 67: mau_found = False
> 67: for log in logs:
> 67: if 'PROTOCOL' in log[0]:
> 67: if "@transfer" in log[2] and TEST_ADDR_1 in log[2] and
> "MAU" in log[2]:
> 67: mau_found = True
> 67: break
> 67:
> 67: > self.assertTrue(mau_found)
> 67: E AssertionError: False is not true
> 67:
> /home/runner/work/qpid-dispatch/qpid-dispatch/qpid-dispatch/tests/system_tests_log_level_update.py:288:
> AssertionError
> 67: - generated xml file:
> /__w/qpid-dispatch/qpid-dispatch/qpid-dispatch/build/tests/junitxmls/system_tests_log_level_update.xml
> -
> 67: =========================== short test summary info
> ============================
> 67: FAILED
> ::EnableConnectionLevelInterRouterTraceTest::test_inter_router_protocol_trace
> 67: ========================= 1 failed, 7 passed in 12.90s
> =========================
> 33/38 Test #67: system_tests_log_level_update ...........***Failed 13.18
> sec {noformat}
>
> https://github.com/ganeshmurthy/qpid-dispatch/runs/4526076646?check_suite_focus=true#step:27:4255
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
