[
https://issues.apache.org/jira/browse/PROTON-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17463987#comment-17463987
]
ASF GitHub Bot commented on PROTON-2308:
----------------------------------------
gemmellr commented on a change in pull request #346:
URL: https://github.com/apache/qpid-proton/pull/346#discussion_r774059843
##########
File path: cpp/src/link_test.cpp
##########
@@ -23,9 +23,121 @@
#include <proton/sender_options.hpp>
#include <proton/receiver_options.hpp>
#include <proton/container.hpp>
+#include <proton/connection.hpp>
+#include <proton/connection_options.hpp>
+#include <proton/listen_handler.hpp>
+#include <proton/listener.hpp>
+#include <proton/messaging_handler.hpp>
+#include <proton/types.hpp>
+#include <proton/message.hpp>
+#include <proton/target_options.hpp>
+#include <proton/source_options.hpp>
+#include <proton/delivery.hpp>
#include <iostream>
+#include <map>
+#include <condition_variable>
+#include <mutex>
+#include <thread>
+
+namespace {
+std::mutex m;
+std::condition_variable cv;
+bool listener_ready = false;
+int listener_port;
+const std::string DYNAMIC_ADDRESS = "test_dynamic_address";
+} // namespace
+
+class test_recv : public proton::messaging_handler {
+ private:
+ class listener_ready_handler : public proton::listen_handler {
+ void on_open(proton::listener &l) override {
+ {
+ std::lock_guard<std::mutex> lk(m);
+ listener_port = l.port();
+ listener_ready = true;
+ }
+ cv.notify_one();
+ }
+ };
+
+ std::string url;
+ proton::listener listener;
+ listener_ready_handler listen_handler;
+
+ public:
+ test_recv(const std::string &s) : url(s) {}
+
+ void on_container_start(proton::container &c) override {
+ listener = c.listen(url, listen_handler);
+ }
+
+ void on_receiver_open(proton::receiver& r) override {
+ std::map<proton::symbol,proton::value>
m_sender({{proton::symbol("supported-dist-modes"), proton::symbol("move")}});
+ std::map<proton::symbol,proton::value> props =
r.target().dynamic_properties();
+
+ ASSERT(r.target().dynamic());
+ ASSERT(r.target().address().empty());
Review comment:
If the API is intended to return an empty string then I think that its
ok if that is all the test verifies. I dont know about adding use of the C
function in the C++ tests, not my area of expertise at all, though if it was
easy and not frowned upon then I personally would consider verifying the value
fully to be worthwhile. But if isnt simple or is frowned upon to do such things
then thats fair enough.
I wasnt suggesting you add C tests (though I do think they _should_ already
exist)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] Add support for setting Dynamic Node Properties
> -----------------------------------------------------
>
> Key: PROTON-2308
> URL: https://issues.apache.org/jira/browse/PROTON-2308
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
> Affects Versions: proton-c-0.33.0
> Reporter: James Henry
> Assignee: Rakhi Kumari
> Priority: Major
> Labels: api-addition
>
> Requesting support for setting the dynamic node properties be added to the
> source and target options.
> This would allow the setting of termini node properties for senders and
> receivers.
> Similar to the following request made for Python here:
> https://issues.apache.org/jira/browse/PROTON-816
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
