[
https://issues.apache.org/jira/browse/DISPATCH-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17468666#comment-17468666
]
ASF GitHub Bot commented on DISPATCH-2299:
------------------------------------------
jiridanek commented on a change in pull request #1468:
URL: https://github.com/apache/qpid-dispatch/pull/1468#discussion_r778139814
##########
File path: tools/qdmanage
##########
@@ -24,7 +24,9 @@ import json
import re
from collections.abc import Mapping, Sequence
-import qpid_dispatch_site # noqa: F401 # imported for side-effects (inserts
to sys.path)
+import qpid_dispatch_site
+qpid_dispatch_site.populate_pythonpath()
Review comment:
Yes, but then we would have it called every time the file is included.
Sometimes, you want to include the file and not add into pythonpath.
Also, importing for side-effects only is strange, I thought making this into
explicit call is an improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> re-enable system_tests_http delete listeners with libwebsockets >= 4.2
> ----------------------------------------------------------------------
>
> Key: DISPATCH-2299
> URL: https://issues.apache.org/jira/browse/DISPATCH-2299
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Container
> Affects Versions: 1.18.0
> Reporter: Jiri Daněk
> Priority: Major
>
> The upstream issue in libwebsockets was fixed. The test can be reenabled
> # https://libwebsockets.org/pipermail/libwebsockets/2021-January/008852.html
> # https://github.com/warmcat/libwebsockets/issues/2327
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
