[
https://issues.apache.org/jira/browse/DISPATCH-2305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472100#comment-17472100
]
ASF GitHub Bot commented on DISPATCH-2305:
------------------------------------------
kgiusti commented on a change in pull request #1475:
URL: https://github.com/apache/qpid-dispatch/pull/1475#discussion_r781286944
##########
File path: python/qpid_dispatch/management/qdrouter.json
##########
@@ -2358,21 +2358,18 @@
"maxFrameSize": {
"type": "integer",
"description": "The largest frame, in bytes, that may be
sent on this connection. Non-zero policy values overwrite values specified for
a listener object (AMQP Open, max-frame-size).",
- "default": 16384,
Review comment:
Why have two sets of defaults then (one in the entity's definition in
the schema [e.g. listener], and one in the policy)? My point is defining a
policy should not force another set of defaults when the entity itself defines
its defaults.
Otherwise we're maintaining two sets of defaults which need to be kept in
sync else we trigger this bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> policy code overrides configured connection settings by default
> ---------------------------------------------------------------
>
> Key: DISPATCH-2305
> URL: https://issues.apache.org/jira/browse/DISPATCH-2305
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Policy Engine
> Affects Versions: 1.18.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
>
> The following connection/settings attributes may be configured via
> management/configuration file:
> * maxFrameSize
> * maxSessions
> * maxSessionFrames (session window).
> These attributes may also be configured via policy. The policy configuration
> takes precedence.
> If a policy is configured but does *not specify* override values for any of
> the above attributes, one would expect any existing configured values would
> take effect.
> However this is not the case. If you set values for the above attributes in
> the router config file, and you define a matching policy that does not
> override these values, the policy will overwrite your configured values with
> what policy thinks is the default value
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
