On 26 July 2010 15:39, <[email protected]> wrote: > Author: grkvlt > Date: Mon Jul 26 14:39:33 2010 > New Revision: 979316 > > URL: http://svn.apache.org/viewvc?rev=979316&view=rev > Log: > QPID-2744: Make JMSPropertiesTest deal with both types of error messages > > Modified: > > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/message/JMSPropertiesTest.java > > Modified: > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/message/JMSPropertiesTest.java > URL: > http://svn.apache.org/viewvc/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/message/JMSPropertiesTest.java?rev=979316&r1=979315&r2=979316&view=diff > ============================================================================== > --- > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/message/JMSPropertiesTest.java > (original) > +++ > qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/test/unit/message/JMSPropertiesTest.java > Mon Jul 26 14:39:33 2010 > @@ -100,7 +100,8 @@ public class JMSPropertiesTest extends Q > catch (MessageFormatException mfe) > { > // Check the error message > - assertTrue("Incorrect error message: " + mfe.getMessage(), > mfe.getMessage().contains("Object is null")); > + assertEquals("Incorrect error message", > + isBroker010() ? "Object is null" : "Only Primitives > objects allowed Object is:null", mfe.getMessage()); > } > > // send it
As the 0-10 code base was recently modified to throw "Object is null" I would suggest we update it to throw the same exception text as the 0-8/9 code path.. this will simplify testing and simplify the user experience. Martin > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] > > -- Martin Ritchie --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
