[
https://issues.apache.org/jira/browse/DISPATCH-2328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17490546#comment-17490546
]
ASF GitHub Bot commented on DISPATCH-2328:
------------------------------------------
jiridanek commented on a change in pull request #1514:
URL: https://github.com/apache/qpid-dispatch/pull/1514#discussion_r804152531
##########
File path: tests/c_unittests/CMakeLists.txt
##########
@@ -20,7 +20,7 @@
# -fno-inline: just to be extra sure, no particular reason so far
# -fno-builtin: GCC would optimize e.g. abs() and we would not be able to stub
# -fno-stack-protector:
https://stackoverflow.com/questions/12201625/disable-using-sprintf-chk
-# -D_FORTIFY_SOURCE=0: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
+# -U_FORTIFY_SOURCE: for Ubuntu with -O1+,
https://stackoverflow.com/questions/34907503/gcc-fread-chk-warn-warning
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CXX_STANDARD_FLAGS} -fno-inline
-fno-builtin -fno-stack-protector -U_FORTIFY_SOURCE")
Review comment:
while I think that setting `_FORTIFY_SOURCE` to disable tests is silly
and such ideas should not be encouraged, you have a point saying that
undefining options the way it's there now is not a good practice.
Ubuntu forces that FORTIFY_SOURCE on me whenever I do -O1! I felt I had to
strike back.
thanks for looking it over, lets see what jenkins says
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> c_unittests failing on RHEL 7
> -----------------------------
>
> Key: DISPATCH-2328
> URL: https://issues.apache.org/jira/browse/DISPATCH-2328
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Tests
> Reporter: Ganesh Murthy
> Assignee: Jiri Daněk
> Priority: Major
>
> {noformat}
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:42:
> TEST CASE: test_safe_snprintf
> vsnprintf failure (_STUB_)
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:94:
> ERROR: CHECK( 0 == len ) is NOT correct!
> values: CHECK( 0 == 9 )
> /home/jenkins/workspace/rh-qpid-dispatch-dist-el7-main/build/BUILD/qpid-dispatch-1.19.0/tests/c_unittests/test_terminus.cpp:95:
> ERROR: CHECK( '\0' == output[0] ) is NOT correct!
> values: CHECK( 0 == 115 ) {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
