[
https://issues.apache.org/jira/browse/DISPATCH-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17493235#comment-17493235
]
ASF GitHub Bot commented on DISPATCH-2234:
------------------------------------------
jiridanek commented on a change in pull request #1517:
URL: https://github.com/apache/qpid-dispatch/pull/1517#discussion_r807960231
##########
File path: console/react/src/App.js
##########
@@ -28,26 +29,22 @@ import "@patternfly/patternfly/components/Nav/nav.css";
import { QDRService } from "./common/qdrService";
import "./App.css";
import PageLayout from "./overview/dashboard/layout";
-class App extends Component {
- state = {};
-
- render() {
- // service is passed in to make testing easier
- const service = new QDRService();
- // also, a router is used here to provide PageLayout with a history
property
- return (
- <Router>
- <div className="App pf-m-redhat-font">
- <Route
- path="/"
- render={props => (
- <PageLayout service={service} {...props}
config={this.props.config} />
- )}
- />
- </div>
- </Router>
- );
- }
+
+function App(props) {
+
+ // service is passed in to make testing easier
+ let service = new QDRService();
+
+ // also, a router is used here to provide PageLayout with a history property
+ let history = createHashHistory({ window });
+
+ return (
+ <HistoryRouter history={history}>
Review comment:
Because the code of some components nested further in needs to have
`history` instance in properties. That is not available in react-router-dom v6
unless I put it there. And `HistoryRouter` is the way to inject `history`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Update JavaScript console packages for the 1.19.0 release
> ---------------------------------------------------------
>
> Key: DISPATCH-2234
> URL: https://issues.apache.org/jira/browse/DISPATCH-2234
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Console
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: 1.19.0
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
