Jiri Daněk created DISPATCH-2331:
------------------------------------

             Summary: Modernize webconsole code related to react-router-dom
                 Key: DISPATCH-2331
                 URL: https://issues.apache.org/jira/browse/DISPATCH-2331
             Project: Qpid Dispatch
          Issue Type: Improvement
          Components: Console
    Affects Versions: 1.19.0
            Reporter: Jiri Daněk
             Fix For: 1.20.0


Suggestions from https://github.com/apache/qpid-dispatch/pull/1517

{quote}
* navigating between pages; which is now done inconsistently, either with 
<Navigate>, or navigate(), or through history.
* the page structure which is supposed to use the <Outlet> feature but it does 
not
{quote}

and

{quote}
Probably one of the things to do is refactor the PageLayout component as a 
function (but this is out of the scope of this PR honestly) to use directly 
hooks. So we can avoid passing history and use directly useNavigate and 
useLocation. Then probably we can avoid passing {...props } because without 
typescript we lose a bit the control of what we inject in the component. 
Moreover the High order component 'WithRoute' will be deleted
{quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to