[
https://issues.apache.org/jira/browse/QPIDJMS-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503568#comment-17503568
]
ASF GitHub Bot commented on QPIDJMS-553:
----------------------------------------
gemmellr commented on pull request #45:
URL: https://github.com/apache/qpid-jms/pull/45#issuecomment-1062882201
Your latest version is a bit simpler, but for reference I banged together
the 'trivial synchronized map' version I was thinking of and some other
simplifications and changes from previous feedback:
https://github.com/gemmellr/qpid-jms/tree/pr45-netty-sharing-simpler
I started it yesterday and didnt rebase so its different than your current
version. It also changed the indents in a lot of places as yours are 'wrong' in
many cases (3-spaced) so isnt as trivially comparable
It is definitely simpler, though still more elaborate than it initially
seemed it might be, because of the needed key + holder loop. I expect that
possibly could be simplified too though without e.g some more 'interesting' use
of the map (e.g have one holder for everything as key and value, use a 'equals
but different' object for the lookups) or even some other data structure
(basically its acting more as a set but with a kind of reverse-lookup needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> Shared Netty event loop group
> -----------------------------
>
> Key: QPIDJMS-553
> URL: https://issues.apache.org/jira/browse/QPIDJMS-553
> Project: Qpid JMS
> Issue Type: New Feature
> Reporter: Francesco Nigro
> Priority: Major
>
> One of the most interesting feature of Netty while using KQueue/NIO/Epoll in
> non-blocking mode is to be able to handle many connections with few threads;
> this is going to be critical and even more important with the upcoming
> IO_URING support, where the time spent on the Netty event loop to handle
> network syscalls will be further reduced, allowing syscall batching across
> different connections.
> Having the chance to handle many client connections with few Netty threads is
> already beneficial in constrained environments (containers with few cores) in
> order to reduce the native and heap memory usage.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
