[
https://issues.apache.org/jira/browse/PROTON-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17508763#comment-17508763
]
ASF GitHub Bot commented on PROTON-2487:
----------------------------------------
DreamPearl commented on a change in pull request #355:
URL: https://github.com/apache/qpid-proton/pull/355#discussion_r829969732
##########
File path: cpp/src/sender.cpp
##########
@@ -71,12 +72,17 @@ tracker sender::send(const message &message, const binary
&tag) {
pn_object(),
pn_dtag((reinterpret_cast<const char *>(&tag[0])), tag.size()));
std::vector<char> buf;
- message.encode(buf);
+
+ Tracing& ot = Tracing::getTracing();
+ tracker track = make_wrapper<tracker>(dlv);
+ ot.message_encode(message, buf, tag, track);
+
assert(!buf.empty());
pn_link_send(pn_object(), &buf[0], buf.size());
pn_link_advance(pn_object());
- if (pn_link_snd_settle_mode(pn_object()) == PN_SND_SETTLED)
+ if (pn_link_snd_settle_mode(pn_object()) == PN_SND_SETTLED) {
pn_delivery_settle(dlv);
+ }
Review comment:
Removed braces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
> [cpp] Implement distributed tracing
> -----------------------------------
>
> Key: PROTON-2487
> URL: https://issues.apache.org/jira/browse/PROTON-2487
> Project: Qpid Proton
> Issue Type: New Feature
> Components: cpp-binding
> Affects Versions: proton-c-0.37.0
> Reporter: Rakhi Kumari
> Assignee: Rakhi Kumari
> Priority: Major
> Fix For: proton-c-0.38.0
>
>
> Implement distributed tracing using opentelemetry.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
