[
https://issues.apache.org/jira/browse/PROTON-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567858#comment-17567858
]
ASF GitHub Bot commented on PROTON-2095:
----------------------------------------
jiridanek commented on code in PR #375:
URL: https://github.com/apache/qpid-proton/pull/375#discussion_r923059274
##########
python/proton/_wrapper.py:
##########
@@ -138,6 +142,11 @@ def __repr__(self) -> str:
self.__class__.__name__,
id(self), addressof(self._impl))
+# print(f"log _wrapper line 144 {pn_py2void(Wrapper)=} ")
+# PYCTX = int(pn_py2void(Wrapper))
+# print(f"log _wrapper line 144 : type {type(Wrapper)} \n wrapper {Wrapper}")
+handle = ffi.new_handle(Wrapper)
+# PYCTX = int(Wrapper)
-PYCTX = int(pn_py2void(Wrapper))
-addressof = int
Review Comment:
It is better to directly compare with `==`, but if I really address as an
`int`, then
```
int(ffi.cast("intptr_t", p))
```
https://groups.google.com/g/python-cffi/c/lwmb1xUqJRQ
> Move away from SWIG to CFFI
> ---------------------------
>
> Key: PROTON-2095
> URL: https://issues.apache.org/jira/browse/PROTON-2095
> Project: Qpid Proton
> Issue Type: Wish
> Components: python-binding
> Affects Versions: proton-c-0.29.0, proton-c-future
> Reporter: Omer Katz
> Assignee: Arunagirinadan Sudharshan
> Priority: Major
> Fix For: proton-c-future
>
>
> SWIG is fine but we're not using it for anything other than exporting all of
> proton-c's API as is.
> Unfortunately SWIG only generates CPython extension bindings. This may be a
> problem on PyPy where CPython extensions are either slow or simply won't
> compile.
> Unlike SWIG, CFFI is portable both on CPython and PyPy.
> It also satisfies the same requirements as SWIG currently does.
> In addition, calls to CFFI simply release the GIL which will help
> parallelizing Python applications using threads.
> By using CFFI we can also get rid of all of our setup.py code and simply use
> it to build the extension. We will also no longer have problems building
> wheels.
> The newest version of CFFI supports pkg-config so we can use that to find
> proton-c easily.
> I'm willing to help with the refactor but I'll need a mentor since I'm not
> familiar with the code base.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
