[
https://issues.apache.org/jira/browse/DISPATCH-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17613176#comment-17613176
]
ASF GitHub Bot commented on DISPATCH-2339:
------------------------------------------
codecov-commenter commented on PR #1605:
URL: https://github.com/apache/qpid-dispatch/pull/1605#issuecomment-1265292926
#
[Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/1605?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#1605](https://codecov.io/gh/apache/qpid-dispatch/pull/1605?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(6149f06) into
[main](https://codecov.io/gh/apache/qpid-dispatch/commit/76fb83c679967beaac808df76b34feb2fa638020?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(76fb83c) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1605 +/- ##
==========================================
- Coverage 85.84% 85.82% -0.03%
==========================================
Files 110 110
Lines 24746 24746
==========================================
- Hits 21243 21238 -5
- Misses 3503 3508 +5
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-dispatch/pull/1605?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=)
| `85.48% <0.00%> (-0.95%)` | :arrow_down: |
|
[src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=)
| `85.71% <0.00%> (-0.87%)` | :arrow_down: |
|
[src/router\_core/delivery.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2RlbGl2ZXJ5LmM=)
| `93.16% <0.00%> (-0.37%)` | :arrow_down: |
|
[src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9ub2RlLmM=)
| `93.07% <0.00%> (-0.10%)` | :arrow_down: |
|
[src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=)
| `86.79% <0.00%> (ø)` | |
|
[src/router\_core/modules/edge\_router/edge\_mgmt.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvZWRnZV9tZ210LmM=)
| `85.14% <0.00%> (+0.99%)` | :arrow_up: |
|
[...router\_core/modules/edge\_router/link\_route\_proxy.c](https://codecov.io/gh/apache/qpid-dispatch/pull/1605/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvZWRnZV9yb3V0ZXIvbGlua19yb3V0ZV9wcm94eS5j)
| `82.84% <0.00%> (+4.14%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> Update console to React 18 and react-scripts 5
> ----------------------------------------------
>
> Key: DISPATCH-2339
> URL: https://issues.apache.org/jira/browse/DISPATCH-2339
> Project: Qpid Dispatch
> Issue Type: Improvement
> Components: Console
> Affects Versions: 1.19.0
> Reporter: Jiri Daněk
> Priority: Major
> Fix For: 1.20.0
>
>
> {noformat}
> $ npx react-scripts start
> (node:836641) [DEP_WEBPACK_DEV_SERVER_ON_AFTER_SETUP_MIDDLEWARE]
> DeprecationWarning: 'onAfterSetupMiddleware' option is deprecated. Please use
> the 'setupMiddlewares' option.
> (Use `node --trace-deprecation ...` to show where the warning was created)
> (node:836641) [DEP_WEBPACK_DEV_SERVER_ON_BEFORE_SETUP_MIDDLEWARE]
> DeprecationWarning: 'onBeforeSetupMiddleware' option is deprecated. Please
> use the 'setupMiddlewares' option.
> Starting the development server...
> Failed to compile.
> Module not found: Error: Can't resolve 'os' in
> '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib'
> BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core
> modules by default.
> This is no longer the case. Verify if you need this module and configure a
> polyfill for it.
> If you want to include a polyfill, you need to:
> - add a fallback 'resolve.fallback: { "os":
> require.resolve("os-browserify/browser") }'
> - install 'os-browserify'
> If you don't want to include a polyfill, you can use an empty module like
> this:
> resolve.fallback: { "os": false }
> ERROR in ./node_modules/rhea/lib/connection.js 36:9-22
> Module not found: Error: Can't resolve 'os' in
> '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib'
> BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core
> modules by default.
> This is no longer the case. Verify if you need this module and configure a
> polyfill for it.
> If you want to include a polyfill, you need to:
> - add a fallback 'resolve.fallback: { "os":
> require.resolve("os-browserify/browser") }'
> - install 'os-browserify'
> If you don't want to include a polyfill, you can use an empty module like
> this:
> resolve.fallback: { "os": false }
> ERROR in ./node_modules/rhea/lib/connection.js 38:11-26
> Module not found: Error: Can't resolve 'path' in
> '/home/jdanek/repos/qpid/qpid-dispatch/console/react/node_modules/rhea/lib'
> BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core
> modules by default.
> This is no longer the case. Verify if you need this module and configure a
> polyfill for it.
> If you want to include a polyfill, you need to:
> - add a fallback 'resolve.fallback: { "path":
> require.resolve("path-browserify") }'
> - install 'path-browserify'
> If you don't want to include a polyfill, you can use an empty module like
> this:
> resolve.fallback: { "path": false }
> webpack compiled with 2 errors
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
