[
https://issues.apache.org/jira/browse/QPID-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622652#comment-17622652
]
ASF GitHub Bot commented on QPID-7148:
--------------------------------------
jiridanek opened a new pull request, #33:
URL: https://github.com/apache/qpid-cpp/pull/33
Turns out, CMake is happy to generate a lot of the QpidConfig.cmake file for
us, see
* https://gitlab.kitware.com/cmake/cmake/-/issues/19560
*
https://cmake.org/cmake/help/latest/manual/cmake-packages.7.html#creating-packages
*
https://cmake.org/cmake/help/latest/guide/importing-exporting/index.html#exporting-targets
*
https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#example-generating-package-files
*
https://cmake.org/cmake/help/latest/guide/tutorial/Packaging%20Debug%20and%20Release.html
This is analogous change to PROTON-2254 for Qpid Proton.
> Update CMake to use more modern simpler features
> ------------------------------------------------
>
> Key: QPID-7148
> URL: https://issues.apache.org/jira/browse/QPID-7148
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Build
> Reporter: Andrew Stitcher
> Assignee: Andrew Stitcher
> Priority: Major
>
> The CMake build system for Qpid especially the Windows relevant bits can be
> improved and made easier to understand by using newer features of more recent
> CMake releases (especially post 3.0 features).
> This will allow us to remove the warnings:
> {noformat}
> CMake Warning (dev) at src/msvc.cmake:31 (get_target_property):
> Policy CMP0026 is not set: Disallow use of the LOCATION target property.
> Run "cmake --help-policy CMP0026" for policy details. Use the cmake_policy
> command to set the policy and suppress this warning.
>
> The LOCATION property should not be read from target "qpidtypes". Use the
> target name directly with add_custom_command, or use the generator
> expression $<TARGET_FILE>, as appropriate.
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
