[
https://issues.apache.org/jira/browse/PROTON-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628455#comment-17628455
] ASF GitHub Bot commented on PROTON-1870: ---------------------------------------- codecov-commenter commented on PR #261: URL: https://github.com/apache/qpid-proton/pull/261#issuecomment-1302486168 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/261?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report > Merging [#261](https://codecov.io/gh/apache/qpid-proton/pull/261?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23f1a13) into [main](https://codecov.io/gh/apache/qpid-proton/commit/3f13a38e0648a1dc19d94ea88bde387f750752f7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3f13a38) will **increase** coverage by `18.64%`. > The diff coverage is `n/a`. > :exclamation: Current head 23f1a13 differs from pull request most recent head 6e64e9b. Consider uploading reports for the commit 6e64e9b to get more accurate results ```diff @@ Coverage Diff @@ ## main #261 +/- ## =========================================== + Coverage 69.69% 88.34% +18.64% =========================================== Files 370 47 -323 Lines 69864 2394 -67470 =========================================== - Hits 48695 2115 -46580 + Misses 21169 279 -20890 ``` | [Impacted Files](https://codecov.io/gh/apache/qpid-proton/pull/261?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [python/tests/proton\_tests/transport.py](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHl0aG9uL3Rlc3RzL3Byb3Rvbl90ZXN0cy90cmFuc3BvcnQucHk=) | | | | [build/c/src/core/object/string.c](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnVpbGQvYy9zcmMvY29yZS9vYmplY3Qvc3RyaW5nLmM=) | | | | [c/tests/proactor\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9wcm9hY3Rvcl90ZXN0LmNwcA==) | | | | [c/tests/pn\_test\_test.cpp](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy90ZXN0cy9wbl90ZXN0X3Rlc3QuY3Bw) | | | | [c/src/core/types.c](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS90eXBlcy5j) | | | | [cpp/src/transport.cpp](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy90cmFuc3BvcnQuY3Bw) | | | | [cpp/include/proton/scalar\_base.hpp](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL3NjYWxhcl9iYXNlLmhwcA==) | | | | [cpp/include/proton/codec/vector.hpp](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL2luY2x1ZGUvcHJvdG9uL2NvZGVjL3ZlY3Rvci5ocHA=) | | | | [c/src/core/engine.c](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Yy9zcmMvY29yZS9lbmdpbmUuYw==) | | | | [cpp/src/connection\_driver.cpp](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y3BwL3NyYy9jb25uZWN0aW9uX2RyaXZlci5jcHA=) | | | | ... and [313 more](https://codecov.io/gh/apache/qpid-proton/pull/261/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | | :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) > better logging for ssl > ---------------------- > > Key: PROTON-1870 > URL: https://issues.apache.org/jira/browse/PROTON-1870 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding > Affects Versions: proton-0.9.1, proton-c-0.31.0 > Reporter: Gordon Sim > Priority: Major > Labels: logging, tls, usability > > Would be nice to have better logging for ssl connections, particularly where > they fail, e.g. the sni used, the ca the peer cert is signed with etc -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
