[ 
https://issues.apache.org/jira/browse/PROTON-2654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643445#comment-17643445
 ] 

ASF GitHub Bot commented on PROTON-2654:
----------------------------------------

astitcher commented on code in PR #382:
URL: https://github.com/apache/qpid-proton/pull/382#discussion_r1039811631


##########
cpp/src/map_test.cpp:
##########
@@ -114,6 +114,23 @@ void test_value() {
     ASSERT_THROWS(conversion_error, m.value(bad));
 }
 
+void test_copy_constructor() {
+    std::map<string, scalar> sm;
+    sm["a"] = 2;
+    sm["b"] = 3;

Review Comment:
   or even (syntax might not be 100% correct):
   `auto m = std::map<string,scalar>{{"a", 2}, {"b", 3}};`





> [cpp] Tests for newly added map constructors
> --------------------------------------------
>
>                 Key: PROTON-2654
>                 URL: https://issues.apache.org/jira/browse/PROTON-2654
>             Project: Qpid Proton
>          Issue Type: Test
>          Components: cpp-binding
>            Reporter: Rakhi Kumari
>            Assignee: Rakhi Kumari
>            Priority: Major
>
> Tests for https://issues.apache.org/jira/browse/PROTON-2481 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to