[
https://issues.apache.org/jira/browse/QPID-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709999#comment-17709999
]
ASF subversion and git services commented on QPID-5836:
-------------------------------------------------------
Commit 4123547a7514ffd6d650280d5ae8831613e635d4 in qpid-python's branch
refs/heads/main from Jiri Daněk
[ https://gitbox.apache.org/repos/asf?p=qpid-python.git;h=4123547 ]
QPID-8170: fix exception string from qpid_tests.broker_1_0 tests running
against amqp0-10 broker
Issue was originally introduced in QPID-5836.
```
qpid_tests.broker_1_0.general.GeneralTests.test_anonymous_relay ... fail
Error during setup: Traceback (most recent call last):
File "qpid-python-test", line 347, in run
phase()
File
"/home/jdanek/repos/qpid/qpid-python/qpid/tests/messaging/__init__.py", line
49, in setup
self.conn = self.setup_connection()
File
"/home/jdanek/repos/qpid/qpid-python/qpid/tests/messaging/__init__.py", line
207, in setup_connection
return self.create_connection()
File
"/home/jdanek/repos/qpid/qpid-python/qpid/tests/messaging/__init__.py", line
204, in create_connection
return Connection.establish(self.broker, **opts)
File "/home/jdanek/repos/qpid/qpid-python/qpid/messaging/endpoints.py",
line 111, in establish
conn = Connection(url, **options)
File "/home/jdanek/repos/qpid/qpid-python/qpid/messaging/endpoints.py",
line 209, in __init__
raise ConnectionError("Connection option 'protocol' value '" + value + "'
unsupported (must be amqp0-10)")
TypeError: cannot concatenate 'str' and 'bool' objects
```
> [Python client] Report error when encountering unrecognized connection option
> -----------------------------------------------------------------------------
>
> Key: QPID-5836
> URL: https://issues.apache.org/jira/browse/QPID-5836
> Project: Qpid
> Issue Type: Improvement
> Components: Python Client
> Affects Versions: 0.28
> Reporter: Pavel Moravec
> Assignee: Pavel Moravec
> Priority: Minor
> Fix For: 0.29
>
>
> It would be valuable to report error when unrecognized connection option is
> provided to the connection object in Python client, like c++ client does.
> Currently unrecognized options are silently ignored when creating the
> connection, so user may for example set the mistyped connection options in
> the API doc, and won't be aware of that something went wrong.
> Steps to Reproduce:
> 1. pass non-supported connection option to connection object
> 2. no error/warning appears
>
> Actual results:
> unrecognized connection options are silently ignored
> Expected results:
> An error reported on encountering unrecognized connection option
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
