Hi Sorin, I've been watching your changes wrt the Operational Logging apologies for not replying to your thread over the weekend but I wasn't at a computer.
I think the addition of the toLogString() is the wrong approach here. The responsibility for the logging format should not lie with the individual model objects. >From our discussion on QPID-2780 this doesn't seem like the same approach you are now taking, what changed? The change suggested by the patch on QPID-2835 will introduce inconsistency in the operation logging. Something that its introduction was designed to reduce. The LogActors are that point where the consistency is gained. By locating the LogFormat and the string builder in one location the LogActor has full responsibility of formatting log messages. The approach that I would have taken here is to expose the required common methods for logging on our Session and Connection models. This would then mean that we would have two clean interfaces boundaries: LogActors <-> Logging Framework LogActors <-> Model Objects This would mean that the desire to move to slf4j would be a matter of adjusting the Logging Framework and the adding consistent 1-0 logging would be simply a matter of implementing the model interfaces. The only code that I would expect to see added to the 0-10 Connection code paths is the introduction of Logging commands. The 0-10 Model Objects should have nothing to do with formatting logging statements. Cheers Martin On 31 August 2010 12:18, Sorin Suciu (JIRA) <qpid-...@incubator.apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/QPID-2835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Sorin Suciu updated QPID-2835: > ------------------------------ > > Attachment: qpid-2835.patch > >> Implement connections (CON) operational logging on 0-10 >> ------------------------------------------------------- >> >> Key: QPID-2835 >> URL: https://issues.apache.org/jira/browse/QPID-2835 >> Project: Qpid >> Issue Type: Improvement >> Components: Java Broker >> Affects Versions: 0.7 >> Reporter: Sorin Suciu >> Priority: Minor >> Fix For: 0.7 >> >> Attachments: qpid-2835.patch >> >> >> This is part of the Qpid-2801, dealing with connection operational logging >> on 0-10 code path. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:dev-subscr...@qpid.apache.org > > -- Martin Ritchie --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:dev-subscr...@qpid.apache.org
