jiridanek commented on code in PR #397: URL: https://github.com/apache/qpid-proton/pull/397#discussion_r1171879826
########## c/src/core/connection_driver.c: ########## @@ -43,7 +43,7 @@ static pn_event_t *batch_next(pn_connection_driver_t *d) { /* Log the next event that will be processed */ pn_event_t *next = pn_collector_next(d->collector); if (next && PN_SHOULD_LOG(&d->transport->logger, PN_SUBSYSTEM_EVENT, PN_LEVEL_DEBUG)) { - pni_logger_log_msg_inspect(&d->transport->logger, PN_SUBSYSTEM_EVENT, PN_LEVEL_DEBUG, next, ""); + pni_logger_log_msg_inspect(&d->transport->logger, PN_SUBSYSTEM_EVENT, PN_LEVEL_DEBUG, next, "%s", ""); Review Comment: there is only this one line where the annotations lead to siliness needed not to generate a warning (empty formatting string on gcc generates warning) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org