jiridanek commented on PR #397: URL: https://github.com/apache/qpid-proton/pull/397#issuecomment-1516364984
> I feel that we had these annotations in the original proton code base - I wonder where they went? They are still there, but only applied to two of the functions. I'm rewriting those here to use the macros from Facebook. > In any case I think this is a good direction - but after the 0.39 release! Sure, I only decided to raise the PR now because otherwise I might forget to do it after the release. It found two broken format strings on Linux and quite a lot on Windows, but I guess this is not a release blocker. All about size_t printing; did not investigate, but it looks like somebody was switching to larger type and missed formatting strings while making the change? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
