[
https://issues.apache.org/jira/browse/QPID-2839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12906860#action_12906860
]
Robbie Gemmell commented on QPID-2839:
--------------------------------------
The patch adds commented out log statements, they should be removed:
@@ -658,6 +665,7 @@ public class Subscription_0_10 implements Subscription,
FlowCreditManager.FlowCr
public void restoreCredit(QueueEntry queueEntry)
{ _creditManager.restoreCredit(1, queueEntry.getSize()); + //
_logActor.message(FlowMessages.RESTORED()); }
public void onDequeue(QueueEntry queueEntry)
@@ -719,6 +727,7 @@ public class Subscription_0_10 implements Subscription,
FlowCreditManager.FlowCr
_stopped.set(true);
FlowCreditManager_0_10 creditManager = getCreditManager();
creditManager.clearCredit();
+ // _logActor.message(FlowMessages.REMOVED());
}
@@ -658,6 +665,7 @@ public class Subscription_0_10 implements Subscription,
FlowCreditManager.FlowCr
public void restoreCredit(QueueEntry queueEntry)
{ _creditManager.restoreCredit(1, queueEntry.getSize()); + //
_logActor.message(FlowMessages.RESTORED()); } }
public void onDequeue(QueueEntry queueEntry)
@@ -719,6 +727,7 @@ public class Subscription_0_10 implements Subscription,
FlowCreditManager.FlowCr
_stopped.set(true);
FlowCreditManager_0_10 creditManager = getCreditManager();
creditManager.clearCredit();
+ // _logActor.message(FlowMessages.REMOVED());
}
In the Subscription_0_10 toLogString() method, the updated queueInfo string
generation seems like it could be moved elsewhere to prevent doign expensive
string operations upon every output of every log message. As you are not using
the QueueLogSubject to acquire the queue information it isnt clear that it
should be trimming the result. You are also not using the static log format
string for the queue (as added/moved in the QPID-2832 patch specifically to
make their relationships more clear and to statically import from).
It isnt clear why there are ENFORCED messages in the addCredit() method. The
old FLOW_ENFORCED message for the channel relates to the application of
Producer Side Flow Control, which isnt supported in the 0-10 implementation yet
and also does not relate to how much credit is available. The addCredit()
method then goes on to output the new FlowMessage.START if the subscription
becomes active again, but the active/suspended state message to signal this
type of change already exist.
The section containing the above changes should also really be in the patch for
subscriptions, ie QPID-2394.
> Implement Channel (CHN) and Flow (FLW) operational logging on 0-10
> --------------------------------------------------------------------
>
> Key: QPID-2839
> URL: https://issues.apache.org/jira/browse/QPID-2839
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Affects Versions: 0.7
> Reporter: Sorin Suciu
> Priority: Minor
> Fix For: 0.7
>
> Attachments: qpid-2839.patch
>
>
> This is a part of Qpid-2801dealing with CHN and FLW operational logging on
> 0-10
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
