Hi Martin, That was the intention of the patch on the JIRA yes. I applied it because I dont feel most users will need or want such a prefix, but if someone did then they can apply one of their choice.
I would also like to reduce the verbosity of the log4j derived information that is output for the status logging along the lines of QPID-2847 but as my comments there mention, other limitations make it undesirable to do that right now. Robbie On 9 September 2010 19:33, Martin Ritchie <[email protected]> wrote: > Ah sorry, I clearly was meaning this commit: > http://svn.apache.org/viewvc?rev=995102&view=rev > > On 9 September 2010 19:31, Martin Ritchie <[email protected]> wrote: >> Hi Robbie, >> >> Did you intend to change the default logging prefix? >> >> Would be good to have the default as it was and allow people to >> override the property to the empty string if they so wished. >> >> Cheers >> >> Martin >> >> On 9 September 2010 09:58, <[email protected]> wrote: >>> Author: robbie >>> Date: Thu Sep 9 08:58:14 2010 >>> New Revision: 995352 >>> >>> URL: http://svn.apache.org/viewvc?rev=995352&view=rev >>> Log: >>> QPID-2840: update to fix issue with InVM tests passing in isolation but >>> failing as part of the suite >>> >>> Modified: >>> >>> qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/logging/actors/AbstractActor.java >>> >>> Modified: >>> qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/logging/actors/AbstractActor.java >>> URL: >>> http://svn.apache.org/viewvc/qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/logging/actors/AbstractActor.java?rev=995352&r1=995351&r2=995352&view=diff >>> ============================================================================== >>> --- >>> qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/logging/actors/AbstractActor.java >>> (original) >>> +++ >>> qpid/trunk/qpid/java/broker/src/main/java/org/apache/qpid/server/logging/actors/AbstractActor.java >>> Thu Sep 9 08:58:14 2010 >>> @@ -27,7 +27,7 @@ import org.apache.qpid.server.logging.Ro >>> >>> public abstract class AbstractActor implements LogActor >>> { >>> - public static final String DEFAULT_MSG_PREFIX = >>> System.getProperty("qpid.logging.prefix",""); >>> + public final String _msgPrefix = >>> System.getProperty("qpid.logging.prefix",""); >>> >>> protected RootMessageLogger _rootLogger; >>> >>> @@ -44,7 +44,7 @@ public abstract class AbstractActor impl >>> { >>> if (_rootLogger.isMessageEnabled(this, subject, >>> message.getLogHierarchy())) >>> { >>> - _rootLogger.rawMessage(DEFAULT_MSG_PREFIX + getLogMessage() + >>> subject.toLogString() + message, message.getLogHierarchy()); >>> + _rootLogger.rawMessage(_msgPrefix + getLogMessage() + >>> subject.toLogString() + message, message.getLogHierarchy()); >>> } >>> } >>> >>> @@ -52,7 +52,7 @@ public abstract class AbstractActor impl >>> { >>> if (_rootLogger.isMessageEnabled(this, message.getLogHierarchy())) >>> { >>> - _rootLogger.rawMessage(DEFAULT_MSG_PREFIX + getLogMessage() + >>> message, message.getLogHierarchy()); >>> + _rootLogger.rawMessage(_msgPrefix + getLogMessage() + message, >>> message.getLogHierarchy()); >>> } >>> } >>> >>> >>> >>> >>> --------------------------------------------------------------------- >>> Apache Qpid - AMQP Messaging Implementation >>> Project: http://qpid.apache.org >>> Use/Interact: mailto:[email protected] >>> >>> >> >> >> >> -- >> Martin Ritchie >> > > > > -- > Martin Ritchie > > --------------------------------------------------------------------- > Apache Qpid - AMQP Messaging Implementation > Project: http://qpid.apache.org > Use/Interact: mailto:[email protected] > > --------------------------------------------------------------------- Apache Qpid - AMQP Messaging Implementation Project: http://qpid.apache.org Use/Interact: mailto:[email protected]
