jiridanek commented on PR #409: URL: https://github.com/apache/qpid-proton/pull/409#issuecomment-1880060298
My plan here is to boot up Windows, add all the new warnings on MSVC to the CMakeLists.txt as suppressed, and merge that. I will add comments what these numbers mean. I'll consider putting this into a separate cmake file if the list of suppressions becomes very long. I imagine this might be hard to maintain if we ever wanted to do warnings-as-errors on msvc, or if msvc then fails when compiling on an older version which does not know some particular warning flag (gcc does this). I will not try to do warnings-as-errors on MSVC to be sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
