jiridanek commented on code in PR #419:
URL: https://github.com/apache/qpid-proton/pull/419#discussion_r1444068569
##########
c/src/core/engine.c:
##########
@@ -1645,9 +1645,9 @@ void pn_delivery_dump(pn_delivery_t *d)
printf("{tag=%s, local.type=%" PRIu64 ", remote.type=%" PRIu64 ",
local.settled=%u, "
"remote.settled=%u, updated=%u, current=%u, writable=%u, readable=%u,
"
"work=%u}",
- tag, d->local.type, d->remote.type, d->local.settled,
- d->remote.settled, d->updated, pn_delivery_current(d),
- pn_delivery_writable(d), pn_delivery_readable(d), d->work);
+ tag, d->local.type, d->remote.type, (unsigned)d->local.settled,
+ (unsigned)d->remote.settled, (unsigned)d->updated,
(unsigned)pn_delivery_current(d),
+ (unsigned)pn_delivery_writable(d), (unsigned)pn_delivery_readable(d),
(unsigned)d->work);
Review Comment:
MSVC would be happy to print `bool`s with `%i`, but `%u` it does not like.
Maybe just go with `%i` or `%d` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
