astitcher commented on code in PR #423: URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1564414963
########## python/setup.cfg: ########## @@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0 opentracing = opentracing; jaeger_client [flake8] -# TODO(PROTON-2322) decrease the limit -max-line-length = 150 - -# TODO(PROTON-2322) re-enable all these warnings -ignore = - # do not use bare 'except' - E722, - # imported but unused - F401, - # ambiguous variable name 'l' - E741, Review Comment: I agree that I wouldn't put it in a coding standard myself - but forbidding the letter 'l' to avoid confusion eith the number '1' has some sense IMO and it is in PEP8. Again it's easy enough to avoid if you're checking before commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org
