[
https://issues.apache.org/jira/browse/PROTON-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17836877#comment-17836877
]
ASF GitHub Bot commented on PROTON-2322:
----------------------------------------
astitcher commented on code in PR #423:
URL: https://github.com/apache/qpid-proton/pull/423#discussion_r1564414963
##########
python/setup.cfg:
##########
@@ -28,26 +28,4 @@ install_requires = cffi>=1.0.0
opentracing = opentracing; jaeger_client
[flake8]
-# TODO(PROTON-2322) decrease the limit
-max-line-length = 150
-
-# TODO(PROTON-2322) re-enable all these warnings
-ignore =
- # do not use bare 'except'
- E722,
- # imported but unused
- F401,
- # ambiguous variable name 'l'
- E741,
Review Comment:
I agree that I wouldn't put it in a coding standard myself - but forbidding
the letter 'l' to avoid confusion eith the number '1' has some sense IMO and it
is in PEP8.
Again it's easy enough to avoid if you're checking before commit.
> Fix and remove ignores in flake8 configuration
> ----------------------------------------------
>
> Key: PROTON-2322
> URL: https://issues.apache.org/jira/browse/PROTON-2322
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
> Affects Versions: proton-c-0.34.0
> Reporter: Jiri Daněk
> Assignee: Andrew Stitcher
> Priority: Major
>
> Fixes with autopep8 in PROTON-2320 resolved most of flake8 warnings. There
> are still warnings left that require human consideration and fixing.
> For example, usage of bare {{except}} in the code.
> This must be fixed manually. Fixed issues should then be removed from the
> tox.ini flake8 ignore section.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
