astitcher commented on code in PR #427:
URL: https://github.com/apache/qpid-proton/pull/427#discussion_r1575387644
##########
c/src/proactor/epoll.c:
##########
@@ -1139,6 +1141,21 @@ static pn_event_batch_t
*pconnection_process(pconnection_t *pc, uint32_t events,
}
if (sched_ready) schedule_done(&pc->task);
+ if (pc->first_schedule) {
+ // Normal case: resumed logic from pn_proactor_connect2.
+ // But possible tie: pn_connection_wake() or pn_proactor_disconnect().
Review Comment:
type? "possibility of"?
##########
c/src/proactor/epoll.c:
##########
@@ -1139,6 +1141,21 @@ static pn_event_batch_t
*pconnection_process(pconnection_t *pc, uint32_t events,
}
if (sched_ready) schedule_done(&pc->task);
+ if (pc->first_schedule) {
+ // Normal case: resumed logic from pn_proactor_connect2.
+ // But possible tie: pn_connection_wake() or pn_proactor_disconnect().
Review Comment:
typo? "possibility of"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
