[
https://issues.apache.org/jira/browse/PROTON-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17882141#comment-17882141
]
ASF GitHub Bot commented on PROTON-2790:
----------------------------------------
astitcher commented on code in PR #434:
URL: https://github.com/apache/qpid-proton/pull/434#discussion_r1761602319
##########
c/src/core/transport.c:
##########
@@ -2828,6 +2861,8 @@ uint32_t pn_transport_get_max_frame(pn_transport_t
*transport)
void pn_transport_set_max_frame(pn_transport_t *transport, uint32_t size)
{
// if size == 0, no advertised limit to input frame size.
+ if (transport->open_sent)
+ return; // Too late. Silently disregard request.
Review Comment:
Instead of silently disregarding the request it's probably better to log a
warning.
> Improve session flow control
> ----------------------------
>
> Key: PROTON-2790
> URL: https://issues.apache.org/jira/browse/PROTON-2790
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-c
> Affects Versions: proton-c-0.39.0
> Reporter: Clifford Jansen
> Assignee: Clifford Jansen
> Priority: Major
>
> Current flow control replenishment for the session incoming window only
> occurs when the window reaches 0. This minimizes flow frames on the wire but
> introduces a stall in transfer processing.
> Switching to using a low watermark for the session incoming window would
> allow the application to choose a preferred trade off between transfer stalls
> and FLOW frames.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
