[ 
https://issues.apache.org/jira/browse/QPID-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robbie Gemmell reopened QPID-2858:
----------------------------------

      Assignee: Andrew Kennedy

The newly created FilterManager is not used, so the patches amount to a dead 
code block. The pre-checking and filtering of arguments (not sure the use of 
.getFields() is correct here, getArguments() possibly?) should not be necessary 
as the FilterManagerFactory does this itself.  The FilterManagerFactorycreation 
should have a method added that takes the argument Map instead of Fieldtable 
and then performs the necessary actions, so that functionality for creating 
FilterManagers is contained in the factory rather than the Subscription.

> Implement FilterManager for 0-10 subscriptions
> ----------------------------------------------
>
>                 Key: QPID-2858
>                 URL: https://issues.apache.org/jira/browse/QPID-2858
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: 0.7
>            Reporter: Sorin Suciu
>            Assignee: Andrew Kennedy
>             Fix For: 0.7
>
>         Attachments: qpid-2858.patch, qpid-2858_1.patch
>
>
> On 0-10 path, the subscriptions are created with a null FilterManager,

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscr...@qpid.apache.org

Reply via email to