[ 
https://issues.apache.org/jira/browse/PROTON-2531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17921817#comment-17921817
 ] 

Andrew Stitcher commented on PROTON-2531:
-----------------------------------------

If I make just the obvious API change and make the code produce bytes objects 
rather than str objects then the tests fail because they are testing against 
str objects - I  think that likely again a mistake when we moved to python3 
only. However it's probably a bit too painful to change to bytes now, So I 
suggest we just change the encoding to be latin-1 rather than utf-8. This 
should match the SWIG behaviour even if it really not the most sensible 
behaviour.

> Delivery tag is str while it should be bytes
> --------------------------------------------
>
>                 Key: PROTON-2531
>                 URL: https://issues.apache.org/jira/browse/PROTON-2531
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>            Reporter: Ievgen Popovych
>            Priority: Major
>
> According to AMQP standard delivery tag is ??up to 32 octets of binary 
> data??. Proton C library also has it in binary format.
> But in the Python binding {{Delivery.tag}} is a string, which causes issues 
> when trying to use it (i.e. print/visualize).
> As far as I understand this is down to Swig {{python/cproton.i}} 
> {{wrap_pn_delivery_tag}} (since typemap for {{pn_delivery_tag_t}} seems to be 
> correct)?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to