[ 
https://issues.apache.org/jira/browse/DISPATCH-2025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012889#comment-18012889
 ] 

ASF GitHub Bot commented on DISPATCH-2025:
------------------------------------------

codecov-commenter commented on PR #1090:
URL: https://github.com/apache/qpid-dispatch/pull/1090#issuecomment-3168367206

   ## 
[Codecov](https://app.codecov.io/gh/apache/qpid-dispatch/pull/1090?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
 Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 82.24%. Comparing base 
([`f2e205c`](https://app.codecov.io/gh/apache/qpid-dispatch/commit/f2e205c733558102006ed6dd0a44453c9821c80a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
 to head 
([`49df78f`](https://app.codecov.io/gh/apache/qpid-dispatch/commit/49df78f5f4a42173e6cb2a9a9126e1db68498723?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 383 commits behind head on main.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main    #1090      +/-   ##
   ==========================================
   - Coverage   82.29%   82.24%   -0.05%     
   ==========================================
     Files         111      111              
     Lines       27540    27536       -4     
   ==========================================
   - Hits        22664    22648      -16     
   - Misses       4876     4888      +12     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by 
Sentry](https://app.codecov.io/gh/apache/qpid-dispatch/pull/1090?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   
   :loudspeaker: Have feedback on the report? [Share it 
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test 
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, 
report on failures, and find test suite problems.
   - :package: [JS Bundle 
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save 
yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>




> Compile using C11 language version
> ----------------------------------
>
>                 Key: DISPATCH-2025
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-2025
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>    Affects Versions: 1.16.0
>            Reporter: Jiri Daněk
>            Assignee: Jiri Daněk
>            Priority: Major
>             Fix For: 1.16.0
>
>
> All supported platforms of Dispatch can compile using C11 (or gnu11) language 
> standard.
> There is a caveat that GCC 4.8.5 claims to support C11 atomics but it 
> doesn't. (It does not define {{__STDC_NO_ATOMICS__}} while in fact the 
> [{{stdatomic.h}} header is 
> missing|https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58016].) Thankfully the 
> Dispatch code is able to deal with the situation by using GCC-specific 
> features, so it is not a problem.
> I do not see any downsides to requiring C11 for Dispatch compilation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to