DreamPearl commented on code in PR #437:
URL: https://github.com/apache/qpid-proton/pull/437#discussion_r2348725837
##########
cpp/include/proton/session.hpp:
##########
@@ -105,14 +106,31 @@ PN_CPP_CLASS_EXTERN session : public
internal::object<pn_session_t>, public endp
/// Get user data from this session.
PN_CPP_EXTERN void* user_data() const;
+ PN_CPP_EXTERN void declare_transaction(proton::transaction_handler
&handler, bool settle_before_discharge = false);
+
+ PN_CPP_EXTERN bool transaction_is_empty();
+ PN_CPP_EXTERN bool transaction_is_declared();
+ PN_CPP_EXTERN void transaction_commit();
+ PN_CPP_EXTERN void transaction_abort();
+ PN_CPP_EXTERN void transaction_declare();
+ PN_CPP_EXTERN void transaction_handle_outcome(proton::tracker);
+ PN_CPP_EXTERN void attach_txn_id(proton::tracker t);
+ PN_CPP_EXTERN void transaction_accept(delivery &t);
+ PN_CPP_EXTERN proton::connection transaction_connection() const;
Review Comment:
Is making them private enough to make them internal.. or do you mean
something else? I also marked them as "/// @cond INTERNAL". Will it help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
