gemmellr commented on PR #391: URL: https://github.com/apache/qpid-broker-j/pull/391#issuecomment-4089733910
Moving to require 21 is increasingly reasonable, if possibly still a smidge early (and probably not suited to a 10.0.2 like the Jira indicates), but just in case it wasnt known/considered...there is a fairly simple way to retain Java 17 support and still enable the updated Subject usage required for Java 24+ with just a few-lines in a shim class(es) and a multi-release-jar built on the newest JDK needed. E.g. see [here](https://github.com/apache/artemis/commit/8ec10217acb2403194be7c6bb7377d61624ffe50#diff-69b587111214bc26110691e2d9c2e78249aa3ba2444cae805922713d837ba12d) for the changes used on Artemis when adding Java 25 support, specifically the shim classes [here (24+)](https://github.com/apache/artemis/blob/2.52.0/artemis-commons/src/main/java24/org/apache/activemq/artemis/utils/sm/SecurityManagerShim.java) and [here (17-23)](https://github.com/apache/artemis/blob/2.52.0/artemis-commons/src/main/java/org/apache/activemq/artemis/utils/sm/SecurityManagerShim.java). Noting thats likely far more complicated than what should be needed here as it is actually retaining existing SecurityManager support on JDKs 17-23. Here its possible just the callAs shim method would be needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
