[
https://issues.apache.org/jira/browse/PROTON-2321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18070678#comment-18070678
]
ASF GitHub Bot commented on PROTON-2321:
----------------------------------------
codecov-commenter commented on PR #286:
URL: https://github.com/apache/qpid-proton/pull/286#issuecomment-4179842184
##
[Codecov](https://app.codecov.io/gh/apache/qpid-proton/pull/286?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 67.91%. Comparing base
([`17b5d30`](https://app.codecov.io/gh/apache/qpid-proton/commit/17b5d30ccb3c50cc93b665729eacec2cfa64a637?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache))
to head
([`f8f74b6`](https://app.codecov.io/gh/apache/qpid-proton/commit/f8f74b63182685e158eb980592cf65965878ecbf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 467 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 69.15% 67.91% -1.24%
==========================================
Files 351 351
Lines 69509 69508 -1
==========================================
- Hits 48066 47206 -860
- Misses 21443 22302 +859
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/qpid-proton/pull/286?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test
Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests,
report on failures, and find test suite problems.
</details>
> Add benchmark for pn_data_t initialization (PROTON-2229)
> --------------------------------------------------------
>
> Key: PROTON-2321
> URL: https://issues.apache.org/jira/browse/PROTON-2321
> Project: Qpid Proton
> Issue Type: Test
> Components: proton-c
> Affects Versions: proton-c-0.33.0
> Reporter: Jiri Daněk
> Assignee: Jiri Daněk
> Priority: Major
> Fix For: proton-c-0.35.0
>
>
> {noformat}
> -----------------------------------------------------------------------------------
> Benchmark Time CPU
> Iterations
> -----------------------------------------------------------------------------------
> // size_t size = bytes->size + 0;
> BM_Encode10MbMessage/put_binary count:1 71.7 ms 70.4 ms
> 10
> BM_Encode10MbMessage/put_binary count:10 239 ms 205 ms
> 3
> // size_t size = bytes->size + 1;
> BM_Encode10MbMessage/put_binary count:1 1.25 ms 0.874 ms
> 744
> BM_Encode10MbMessage/put_binary count:10 1059 ms 1045 ms
> 1
> // size_t size = bytes->size + 2;
> BM_Encode10MbMessage/put_binary count:1 1.22 ms 0.916 ms
> 634
> BM_Encode10MbMessage/put_binary count:10 178 ms 135 ms
> 5
> // size_t size = pn_max(bytes->size+1, PNI_INTERN_MINSIZE);
> BM_Encode10MbMessage/put_binary count:1 0.941 ms 0.815 ms
> 783
> BM_Encode10MbMessage/put_binary count:10 1390 ms 1187 ms
> 1
> // size_t size = pn_max(bytes->size+2, PNI_INTERN_MINSIZE);
> BM_Encode10MbMessage/put_binary count:1 0.922 ms 0.811 ms
> 718
> BM_Encode10MbMessage/put_binary count:10 184 ms 144 ms
> 5
> {noformat}
> The above shows that + 1 improves things significantly, but there is a
> scenario where + 2 is even better.
> {code}
> static int pni_data_intern_node(pn_data_t *data, pni_node_t *node)
> {
> pn_bytes_t *bytes = pni_data_bytes(data, node);
> if (!bytes) return 0;
> if (data->buf == NULL) {
> // Heuristic to avoid growing small buffers too much
> // size + 1 to allow for zero termination
> size_t size = pn_max(bytes->size+1, PNI_INTERN_MINSIZE);
> ...
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
