Claudenw commented on code in PR #55:
URL: https://github.com/apache/qpid-jms/pull/55#discussion_r3340213276
##########
qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSupport.java:
##########
@@ -207,6 +207,18 @@ public static String extractErrorMessage(ErrorCondition
errorCondition) {
if (condition != null) {
message = message + " [condition = " + condition + "]";
}
+
+ try {
+ Map<?, ?> info = errorCondition.getInfo();
+ String messageWithInfo = message;
+ if (info != null && !info.isEmpty()) {
+ messageWithInfo = message + " [info = " + info + "]";
+ }
+ return messageWithInfo;
Review Comment:
Is there any chance that the map returned by the `errorCondition.getInfo()`
contains privileged information? Specifically contents of something read from
disk or unobfuscated passwords or access tokens or similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
