[
https://issues.apache.org/jira/browse/QPIDJMS-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18085464#comment-18085464
]
ASF GitHub Bot commented on QPIDJMS-616:
----------------------------------------
gemmellr commented on PR #55:
URL: https://github.com/apache/qpid-jms/pull/55#issuecomment-4601456173
I have previously looked at this. I dont think its a good idea adding the
arbitrary map toString to the exception message, especially not just because a
particular service has decided not to use either of the two other more direct
ways to usefully describe the actual reason they are erroring, in form of the
error description and condition (and to boot whilst misusing the core spec
not-allowed condition). I have not had time to look at alternatives.
> ProviderException losses additional error info
> ----------------------------------------------
>
> Key: QPIDJMS-616
> URL: https://issues.apache.org/jira/browse/QPIDJMS-616
> Project: Qpid JMS
> Issue Type: Bug
> Components: qpid-jms-client
> Affects Versions: 2.9.0
> Reporter: Karthik V
> Priority: Major
> Attachments: image-2025-11-07-13-43-16-346.png
>
>
> Dear Experts,
> When a ProviderException is created in AmqpSupport.java
> ([here),|https://github.com/apache/qpid-jms/blob/a5d9869808c7a4dbbbd108d238b7241d57b90c76/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSupport.java#L181]
> the curicial additional details about the error is lost, which otherwise
> would help identify the root cause of the issue on the client side.
>
> h4. Example :
> We work with Solace as the message broker, and with this there are many
> situations where the ErrorCondition looks like below
> {code:java}
> Rejected{error=Error{condition=amqp:not-allowed, description='SMF AD ack
> response error', info={solace.response_code=400,
> solace.response_text=Document Is Too Large}}}
> {code}
> But as the
> [extractErrorMessage|https://github.com/apache/qpid-jms/blob/a5d9869808c7a4dbbbd108d238b7241d57b90c76/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSupport.java#L199]
> does not also consider the {{_info}} of {{ErrorCondition}}, this information
> is lost in the exception and all we get is :
> {code:java}
> Caused by: org.apache.qpid.jms.provider.ProviderException: SMF AD ack
> response error [condition = amqp:not-allowed]
> {code}
> While the {{SMF AD ack response error [condition = amqp:not-allowed]}} is a
> generic message for a many error situations.
> It would be great to have this information. I am also willing to contribute
> here, as I dont have any clue of the design and code base, any guidance here
> would also help me.
> Thanks & Best Regards,
> Karthik
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
