[
https://issues.apache.org/jira/browse/QPID-2905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12920503#action_12920503
]
Steve Huston commented on QPID-2905:
------------------------------------
Overall the patch looks good. I have two concerns:
1. Importing code from LGPL... IANAL but this looks scary to me. Maybe run this
by Apache legal to be sure it's not opening up Qpid to license problems.
2. Is there a substantive long-term user that's going to maintain the MinGW
stuff? My limited exposure to open source projects and MinGW is that people are
quick to jump up and say they want a project to build on MinGW but are not
willing to put up any resources to keep it up to date over time.
> Fixes for mingw cross-compilation (C++)
> ---------------------------------------
>
> Key: QPID-2905
> URL: https://issues.apache.org/jira/browse/QPID-2905
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client, Code Generator
> Affects Versions: 0.7
> Reporter: Ted Ross
> Assignee: Ted Ross
> Fix For: 0.7
>
> Attachments: cross2.diff
>
>
> In attempting to cross-compile the Qpid trunk in the MinGW environment, a
> number of build errors were seen. Attached to this issue is a patch that
> fixes the errors and builds cleanly on Linux/gcc and MS Visual Studio as well.
> The classes of error discovered are:
> 1) Case-sensitivity of file names (i.e. Secure32.lib => secure32.lib)
> 2) Syntax issues where MSVC is too lenient (semicolon after the closing brace
> of a template function)
> 3) *_EXTERN on DLL APIs. MinGW doesn't like externs on in-line functions,
> requires externs on class names.
> 4) const_case<char*>() needed on LPTSTR arguments in the Windows API
> 5) Unused function arguments need to be commented out
> 6) the *_s variants of ::localtime, ::strncpy, ::strerror can't be used
> Before I commit, I would appreciate some review and feedback on this patch.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:[email protected]
