[
https://issues.apache.org/jira/browse/QPID-7372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18109097#comment-18109097
]
ASF GitHub Bot commented on QPID-7372:
--------------------------------------
dakirily commented on PR #13:
URL: https://github.com/apache/qpid-broker-j/pull/13#issuecomment-5449702605
Thanks for the contribution. Closing this as obsolete/not planned. As noted
in the 2018 review, QPID-7372 intentionally removed the Logback dependency from
broker-core; the broker executable module remained Logback-specific. Newer
Broker-J versions provide the SystemLauncher/SystemLauncherListener separation
for embedding without the Logback startup listener. This PR targets the
historical 6.1.x branch and only guards two casts without removing the
remaining Logback-specific behavior. If the problem is reproducible through the
supported embedding API on a current Broker-J release, please open a new issue
and PR with a regression test.
> [Java Broker] Remove hard dependency on logback from broker-core
> ----------------------------------------------------------------
>
> Key: QPID-7372
> URL: https://issues.apache.org/jira/browse/QPID-7372
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Reporter: Robert Godfrey
> Assignee: Robert Godfrey
> Priority: Major
> Fix For: qpid-java-6.1
>
>
> Currently the SystemConfig class has a hard dependency on LogBack, and forces
> instantiation / resetting the logback config.
> To allow for easier embedding of the broker we can move this instantiation
> out of the core model and into the code use to bootstrap the broker instance.
> We can also move the logback dependent model objects into a separate plugin.
> In this way the System Config (and child Broker) will simply use whatever
> has been set up for them in slf4j and an embedder of the broker could choose
> to use a different logging provider or supply a logback configuration which
> is not managed by the broker itself.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
