gemmellr commented on PR #73: URL: https://github.com/apache/qpid-jms/pull/73#issuecomment-5568283416
I'll have written that mapping text after reading the same bit of the spec, but I recall this has since been discussed a few times long ago, with both the primary authors of the AMQP 1.0 spec indicating that their intent was for the body sectional to be optional like all the other message sections are (and themselves even writing earlier clients that do omit it). I know its also been discussed as something that could be revised in the spec, should it ever be updated. I dont know of any other server definitely having issue with this, but am aware of various clients (and possibly servers) that definitely can do it, so I would actually instead suggest you make RabbitMQ tolerate this instead of giving a decode error. I'll think on this some more, but I'm not sure I think it makes sense to have the clients (and potentially servers) defaulting to do the needless work of encoding and decoding to 'convey nothing' when its been the way it has for over a decade and various other clients have been doing the same for even longer, so I'd possibly even make it a flag if we did it at all. Either way, I would likely not implement it the way it has been here as a side effect of the AmqpCodec class, but within the message objects themselves. It would also need a Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
