[
https://issues.apache.org/jira/browse/QPID-8768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18117889#comment-18117889
]
ASF GitHub Bot commented on QPID-8768:
--------------------------------------
usugumo opened a new pull request, #449:
URL: https://github.com/apache/qpid-broker-j/pull/449
**JIRA Issue**
[QPID-8768](https://issues.apache.org/jira/browse/QPID-8768): [Broker-J]
Remove obsolete LOGBACK-1027 circular-exception workaround
**PR Description**
Logback already handles circular exception references natively, making
Broker-J’s workaround redundant. Proposed changes remove
Logback1027WorkaroundTurboFilter and its registration and cleanup code from
LogbackLoggingSystemLauncherListener, preserving original throwables and
eliminating redundant processing.
> [Broker-J] Remove obsolete LOGBACK-1027 circular-exception workaround
> ---------------------------------------------------------------------
>
> Key: QPID-8768
> URL: https://issues.apache.org/jira/browse/QPID-8768
> Project: Qpid
> Issue Type: Improvement
> Components: Broker-J
> Affects Versions: qpid-java-broker-10.1.0
> Reporter: Takahashi Kiyoshi
> Priority: Minor
>
> Broker-J registers {{{}Logback1027WorkaroundTurboFilter{}}}, introduced as
> part of QPID-7955, to prevent {{StackOverflowError}} when logging exceptions
> with circular references involving causes or suppressed exceptions. The
> filter is intended to detect such references and replace the original
> throwable with a {{StringifiedException}} containing its stack trace as text.
> Logback added native support for circular exception references in
> 1.3.0-alpha10 and backported the fix to 1.2.11, as documented in the [release
> notes|https://logback.qos.ch/news-archive.html]. Broker-J already uses
> Logback 1.6.x, which includes this fix, making the workaround redundant.
> Retaining the workaround adds unnecessary processing and maintenance
> overhead. Replacing the original throwable with a textual representation also
> prevents logging components from accessing its original type and
> cause/suppressed-exception structure.
> I propose removing {{Logback1027WorkaroundTurboFilter}} and the associated
> registration and cleanup code from {{LogbackLoggingSystemLauncherListener}}.
> Exception logging should rely on Logback’s native support, passing the
> original throwable without replacement. Exceptions with circular references
> should be logged without {{StackOverflowError}}, using Logback’s standard
> rendering, including circular-reference markers.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
