kakkar87d commented on PR #453:
URL: https://github.com/apache/qpid-proton/pull/453#issuecomment-6366779465
Fair on both. I'll raise a JIRA for it and retitle the commits once I have
the number.
I've pushed a test, driver_open_oversized_str32 in
connection_driver_test.cpp. It feeds a server driver an open frame whose
container-id is a str32 claiming 0xFFFFFFFF bytes inside a 10 byte list, then
checks the container is rejected. The wrap only happens with a 32-bit size_t,
so it only fails before the change on a 32-bit build. On linux/arm/v7
(bookworm, gcc 12) without the fix it fails with the oversized string accepted
as the remote container:
```
CHECK( pn_connection_remote_container(d.connection) == __null )
with expansion:
"AAAA" == 0
```
With the fix it passes, and so does the rest of c-core-test. On 64-bit it
passes either way, since position+size can't wrap there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
