dakirily commented on PR #451: URL: https://github.com/apache/qpid-broker-j/pull/451#issuecomment-6411757547
Please also handle rename failures that do not throw `RolloverFailure`. In Logback 1.6.3 / 1.6.5, `RenameUtil.rename()` can log warnings and return normally when `File.renameTo()` fails on the same filesystem. Consequently, `rolloverFailed()` isn't called, although the byte counter and pending-rollover flag have already been reset. Logging continues in the original file, but existing bytes are excluded from size checks and no 30-second retry is scheduled. Please restore the rollover state for this failure path and add a regression test using the real rolling policy with a failed rename. The current tests only simulate a thrown `RolloverFailure`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
