[
https://issues.apache.org/jira/browse/QPID-8770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132266#comment-18132266
]
ASF GitHub Bot commented on QPID-8770:
--------------------------------------
dakirily commented on PR #451:
URL: https://github.com/apache/qpid-broker-j/pull/451#issuecomment-6411757547
Please also handle rename failures that do not throw `RolloverFailure`. In
Logback 1.6.3 / 1.6.5, `RenameUtil.rename()` can log warnings and return
normally when `File.renameTo()` fails on the same filesystem. Consequently,
`rolloverFailed()` isn't called, although the byte counter and pending-rollover
flag have already been reset. Logging continues in the original file, but
existing bytes are excluded from size checks and no 30-second retry is
scheduled.
Please restore the rollover state for this failure path and add a regression
test using the real rolling policy with a failed rename. The current tests only
simulate a thrown `RolloverFailure`.
> [Broker-J] FileLogger does not roll on restart when daily rolling is enabled
> ----------------------------------------------------------------------------
>
> Key: QPID-8770
> URL: https://issues.apache.org/jira/browse/QPID-8770
> Project: Qpid
> Issue Type: Bug
> Components: Broker-J
> Affects Versions: qpid-java-broker-10.1.0, qpid-java-broker-10.1.1
> Reporter: Takahashi Kiyoshi
> Priority: Minor
> Fix For: qpid-java-broker-10.2.0
>
>
> When both rollDaily and rollOnRestart are enabled, restarting the broker on
> the same day can append to the existing log instead of rolling it over.
> Expected behavior: archive the existing nonempty log before writing the first
> new log event, using the daily archive filename pattern.
> This appears to be a regression of QPID-8081, introduced during the Logback
> upgrade in QPID-8626.
> The fix should replace the daily triggering policy to restore restart
> rollover, preserve archive numbering, and avoid archiving empty files.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
