[
https://issues.apache.org/jira/browse/PROTON-3005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18144534#comment-18144534
]
ASF subversion and git services commented on PROTON-3005:
---------------------------------------------------------
Commit 98b64e0138d7696313704f95a8a86f2986968017 in qpid-protonj2's branch
refs/heads/1.x from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=qpid-protonj2.git;h=98b64e01 ]
PROTON-3005 Fixes and tests for some ProtonBuffer use cases
Multi-component composite buffers did not behave like a single buffer in
several places along with some other API consistency issues which can lead
to errors when mixing buffers usages.
- Buffer iteration, forward and reverse, lost its place when crossing a
second component boundary.
- indexOf searched beyond the given window and returned an index local to
a component instead of an index into the composite.
- Transfer of bytes to and from a channel exceeded the requested length
when the data spanned multiple components.
- Composing an array of buffers did not flatten nested composites.
- Composite buffer component accessor mishandles read and write offset
advance and loses sync with the parent compositie buffer
- Composite buffer compaction was not correctly recycling older already
read buffers when it should have.
- Check for close in more buffer APIs to ensure consistent exceptions
- Validate more cases of buffer growth via ensureWritable and fix some
edge cases where some allocations can be saved.
- Ensure that the default writeBytes for a ByteBuffer handles little
endian direct buffers correctly for completeness
Also cleans up some stale javadocs and fixes a few minor issues spotted
during tests such as not checking buffer closed in all some cases and
throwing null pointer exception when a more appropriate buffer error
should be thrown.
(cherry picked from commit 032794585fa603002695d5d1d465df5dca2462d6)
> [protonj2] Issues in ProtonBuffer lead to differing behaviors across
> implementations
> ------------------------------------------------------------------------------------
>
> Key: PROTON-3005
> URL: https://issues.apache.org/jira/browse/PROTON-3005
> Project: Qpid Proton
> Issue Type: Bug
> Components: protonj2
> Affects Versions: protonj2-1.5.0
> Reporter: Timothy A. Bish
> Assignee: Timothy A. Bish
> Priority: Minor
> Fix For: protonj2-2.0.0, protonj2-1.6.0
>
>
> Some issues in the various buffer implementations cause issues when used
> inside of composite buffers.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]