[ 
https://issues.apache.org/jira/browse/QPID-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18146266#comment-18146266
 ] 

ASF GitHub Bot commented on QPID-8792:
--------------------------------------

dakirily commented on PR #471:
URL: https://github.com/apache/qpid-broker-j/pull/471#issuecomment-6951884228

   With the default settings, the broker starts the WebSocket closing handshake 
about 1,800 ms into the configured 2,000 ms timeout. If the client’s AMQP Close 
arrives at 1,900 ms, WebSocketReceiver drops it, leaving the AMQP closing 
handshake incomplete. I would keep the full configured window available for the 
AMQP response and start the WebSocket closing handshake as soon as that 
response is processed.




> [Broker-J] Enforce the shared connection-close deadline for WebSocket 
> transport
> -------------------------------------------------------------------------------
>
>                 Key: QPID-8792
>                 URL: https://issues.apache.org/jira/browse/QPID-8792
>             Project: Qpid
>          Issue Type: Bug
>          Components: Broker-J
>    Affects Versions: qpid-java-broker-10.1.1
>            Reporter: Kato Kaito
>            Priority: Minor
>             Fix For: qpid-java-broker-10.2.0
>
>
> QPID-8788 introduced a shared connection-close deadline for TCP/TLS 
> connections. WebSocket connections require equivalent behavior.
> WebSocketConnection currently inherits the default ServerNetworkConnection 
> implementations: setCloseDeadline() does nothing, and abort() delegates to 
> close(). WebSocket close() starts a separate transport timeout while 
> retaining pending writes for draining.
> Consequently, when a peer stops reading and outbound writes are blocked, 
> expiry of connection.closeResponseTimeout can initiate another graceful-close 
> period governed by qpid.port.final_write_timeout. The connection can 
> therefore remain open beyond the configured close-response timeout.
> The WebSocket transport should use the same deadline throughout connection 
> shutdown, including final writes. Once the deadline expires, it should abort 
> the transport without starting another drain timeout.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to