[ 
https://issues.apache.org/jira/browse/QPID-2568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928670#action_12928670
 ] 

Robbie Gemmell commented on QPID-2568:
--------------------------------------

Re: WeakReference, these arent suitable for the task as this reference is the 
only direct reference to the payload and so is responsible for holding the 
content in memory as long as the QueueEntryImpl pointing to it is part of a 
queue. The JIRA was intended for the 0.5.x-dev branch at the time and then 
trunk thereafter, but it turned out the feature had already been implemented on 
trunk. The work was reverted on 0.5.x-dev due to race conditions that made a 
larger reengineering than expected necessary for the desired outcome. Instead 
of this, the QueueEntryList scavenge() feature was ported from trunk instead 
and improved to more agressively remove QueueEntry's, then later ported back to 
trunk in another JIRA.

Upon investigation, the issues leading to the previous reverts also affect 
trunk and so I have raised QPID-2931 to deal with that. 

I am leaving this JIRA open for future use should work on this feature be 
undertaken.

> QueueEntries should release their reference to the message when they deleted
> ----------------------------------------------------------------------------
>
>                 Key: QPID-2568
>                 URL: https://issues.apache.org/jira/browse/QPID-2568
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2.1, M3, M4, 0.5, 0.6
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>             Fix For: 0.7
>
>
> The QueueEntrytImpl currently maintains its reference to the message object 
> even after it is deleted. As a result, if the QE is held onto for any reason 
> then the GarbageCollector is unable to reclaim the memory from the now unused 
> message object.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:[email protected]

Reply via email to